Skip to content

Try out to remove Cython. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fruffy wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Try out to remove Cython. #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d036d1
docker: add Ubuntu 24.04 Dockerfile and update dependencies
p2peek Mar 4, 2026
0bab442
docker: remove unused commented grpc build commands
p2peek Mar 8, 2026
b2c8c00
Try to add a Ubuntu 24 push workflow.
fruffy Mar 8, 2026
be8b922
Try to remove dependency on Cython.
fruffy Mar 29, 2026
51869f9
Try to use a common GRPc.
fruffy Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,11 @@ jobs:
context: .
push: true
tags: p4lang/third-party:${{ steps.get-tag.outputs.tag }}
- name: Build and push Dockerfile.24 image if needed
if: ${{ github.repository == 'p4lang/third-party' && github.event_name == 'push' }}
uses: docker/build-push-action@v2
with:
context: .
file: Dockerfile.24
push: true
tags: p4lang/third-party:${{ steps.get-tag.outputs.tag }}-24
5 changes: 1 addition & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,8 @@ WORKDIR /grpc/
RUN export PYTHON3_VERSION=`python3 -c 'import sys; version=sys.version_info[:3]; print("python{0}.{1}".format(*version))'` && \
echo "import site; site.addsitedir('/usr/local/lib/$PYTHON3_VERSION/site-packages')" \
> /usr/local/lib/$PYTHON3_VERSION/dist-packages/use_site_packages.pth
# We don't use `--ignore-installed` here because otherwise we won't use the
# installed version of the protobuf python package that we copied from the
# protobuf build image.
RUN pip3 install --user -rrequirements.txt
RUN env GRPC_PYTHON_BUILD_WITH_CYTHON=1 pip3 install --user --ignore-installed .
RUN pip3 install --user .

# Build libyang
FROM base-builder as libyang
Expand Down
Loading
Loading