Skip to content

docker: add Ubuntu 24.04 Dockerfile and update dependencies #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fruffy merged 4 commits into from
Apr 8, 2026
+481 −0
Merged

docker: add Ubuntu 24.04 Dockerfile and update dependencies #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d036d1
docker: add Ubuntu 24.04 Dockerfile and update dependencies
p2peek Mar 4, 2026
0bab442
docker: remove unused commented grpc build commands
p2peek Mar 8, 2026
b2c8c00
Try to add a Ubuntu 24 push workflow.
fruffy Mar 8, 2026
956eae8
fix: use grpcio wheel and remove cython dependency
p2peek Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,11 @@ jobs:
context: .
push: true
tags: p4lang/third-party:${{ steps.get-tag.outputs.tag }}
- name: Build and push Dockerfile.24 image if needed
if: ${{ github.repository == 'p4lang/third-party' && github.event_name == 'push' }}
uses: docker/build-push-action@v2
with:
context: .
file: Dockerfile.24
push: true
tags: p4lang/third-party:${{ steps.get-tag.outputs.tag }}-24
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ RUN apt-get update -qq && apt-get install -qq --no-install-recommends \
ldconfig && \
mkdir -p /output/usr/local

RUN pip3 install "Cython<3"
Copy link
Copy Markdown
Contributor

@fruffy fruffy Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need Cython<3? here?

Copy link
Copy Markdown
Contributor Author

@p2peek p2peek Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added during local builds because some grpc python build steps
failed with Cython 3 on Ubuntu 24.04. Pinning Cython<3 ensured the grpc
python package could be compiled successfully.

If this constraint is no longer necessary for the current dependency
versions, I am happy to remove it.

Copy link
Copy Markdown
Contributor

@fruffy fruffy Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let's see if we can remove it to keep things simple.


# Build ccache.
FROM base-builder as ccache
ENV RUN_FROM_BUILD_FARM=yes
Expand Down Expand Up @@ -197,7 +199,10 @@ RUN export PYTHON3_VERSION=`python3 -c 'import sys; version=sys.version_info[:3]
# We don't use `--ignore-installed` here because otherwise we won't use the
# installed version of the protobuf python package that we copied from the
# protobuf build image.


RUN pip3 install --user -rrequirements.txt
RUN pip3 install --user "Cython==0.29.36"
RUN env GRPC_PYTHON_BUILD_WITH_CYTHON=1 pip3 install --user --ignore-installed .

# Build libyang
Expand Down
Loading
Loading