Open
Conversation
antoninbas
reviewed
Dec 9, 2022
Dockerfile
Outdated
| RUN export PYTHON3_VERSION=`python3 -c 'import sys; version=sys.version_info[:3]; print("python{0}.{1}".format(*version))'` && \ | ||
| cd /output/usr/local/lib/$PYTHON3_VERSION/site-packages&& \ | ||
| cat *.pth | grep -v "import sys" | sort -u > docker_protobuf.pth | ||
| RUN pip3 install --user protobuf==3.18.1 |
Member
There was a problem hiding this comment.
I think the intent here was to install the package from source using the checked out repo (hence why the workdir is set to /protobuf/python/). Not sure how important that is, or whether it can be done without a complex workaround.
fruffy
force-pushed
the
simplify_protobuf
branch
from
7665a10 to
de46638
Compare
fruffy
force-pushed
the
simplify_protobuf
branch
from
632ab9c to
753f6d8
Compare
Contributor
Author
|
Trying to get CI to run... does the workflow have to be approved? |
Member
|
Closing to see if it triggers the Github workflow when I re-open the PR |
Member
|
maybe some transient issue, we can see if it resolves itself by Monday |
fruffy
force-pushed
the
simplify_protobuf
branch
from
753f6d8 to
00ad514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WiP: The protobuf installation is needlessly complicated and might cause more issues than it actually solves. Try to simplify it.
It might also make sense to just use Ubuntu's supplied protobuf and grpc. Even though they are older, they will be more consistent with the base system we are using (Ubuntu 20.04).