Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity python #110

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Coverity python #110

merged 2 commits into from
Dec 13, 2022

Conversation

abhijit1kale
Copy link
Contributor

No description provided.

@abhijit1kale
Copy link
Contributor Author

:jenkins

@satish153 satish153 requested review from saynb and satish153 December 12, 2022 07:56
satish153
satish153 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@satish153 satish153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p4lang p4lang deleted a comment from abhijit1kale Dec 12, 2022
saynb
saynb approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@saynb saynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please avoid using internal ticket numbers in p4lang PRs

@abhijit1kale abhijit1kale merged commit 27839c2 into main Dec 13, 2022
@abhijit1kale abhijit1kale deleted the coverity_python branch December 13, 2022 08:16
@abhijit1kale abhijit1kale restored the coverity_python branch December 13, 2022 08:16
@abhijit1kale abhijit1kale deleted the coverity_python branch December 13, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saynb saynb saynb approved these changes

@satish153 satish153 satish153 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhijit1kale @saynb @satish153