Skip to content

Fix a bug of printing the wrong packets during a test failure #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jafingerhut wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix a bug of printing the wrong packets during a test failure #218

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8c66997
Fix a bug of printing the wrong packets during a test failure
jafingerhut Mar 3, 2025
a16698c
Finish the fix
jafingerhut Mar 3, 2025
616c52b
Try a simpler way to install nnpy that seems to work for BMv2
jafingerhut Mar 3, 2025
7ef7a85
Try another variation
jafingerhut Mar 3, 2025
478c217
Use Python venv in CI tests
jafingerhut Mar 6, 2025
85eb4a9
Merge branch 'use-venv-in-ci-testing' into fix-typo-bugs
jafingerhut Mar 6, 2025
514d03e
Merge remote-tracking branch 'up/main' into fix-typo-bugs
jafingerhut Mar 6, 2025
ce1f04e
Revert install-nnpy.sh back to original
jafingerhut Mar 6, 2025
2c24c0c
Merge branch 'main' into fix-typo-bugs
jafingerhut Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ptf/dataplane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,10 +881,10 @@ def format(self):
)
for recent_packet in self.recent_packets:
print("------------------------------")
if isinstance(self.expected_packet, packet.Packet):
if isinstance(recent_packet, packet.Packet):
# Dissect this packet as if it were an instance of
# the expected packet's class.
packet.ls(self.expected_packet.__class__(recent_packet))
packet.ls(recent_packet.__class__(recent_packet))
print("--")
packet.hexdump(recent_packet)
else:
Expand Down