Change CI to use latest available version of pip to install ptf module #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
jafingerhut
changed the title
Collaborator
Author
|
Without these changes, or something similarly effective, Ubuntu 22.04 tests are failing on the I don't know what changed since a few days ago to cause this. |
fruffy
reviewed
Feb 23, 2025
.github/workflows/build.yml
Outdated
|
|
||
| - name: Install | ||
| run: | | ||
| pip --verbose list |
Collaborator
Author
There was a problem hiding this comment.
Extra debug output isn't necessary, until things do not work, and you do not know why :-)
Not strictly necessary for the build to work. Let me know if you want me to remove it, and I will.
Collaborator
Author
There was a problem hiding this comment.
Removed in commit 5.
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
fruffy
approved these changes
Feb 23, 2025
Contributor
fruffy
left a comment
fruffy
left a comment
There was a problem hiding this comment.
Maybe we should modernize this setup at some point. I am not sure if modern Python packaging still requires these tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.