-
Notifications
You must be signed in to change notification settings - Fork 102
Support group_action field in ActionProfileActionSet
#594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e43b23a
Update proto definition
matthewtlam 3fda1df
Add specification changes
matthewtlam edf8e42
Add new enum to p4info.proto
matthewtlam 515f315
Add more info to the spec regarding scope
matthewtlam f1f628d
Fix spacing in spec
matthewtlam 7002c51
Fix white space
matthewtlam 0fa4d9f
Update the documentation
matthewtlam dd59978
Add suggestions to clarify P4Runtime Spec
matthewtlam 0eb4602
Update instantiations of the word global action --> per group action
matthewtlam f128c12
Remove colon
matthewtlam 5ad0ff1
Minor fixes
matthewtlam 285da47
Update with comments
matthewtlam 95790f8
Fix typo
matthewtlam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question for my curiosity: It seems there is nothing fundamental blocking us making it possible to specify group actions when using the "not one-shot" method of configuring action selectors. However, that is not urgent at this time, and can be done in later enhancements to the P4Runtime spec if someone wishes. Is all of that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure on the specifics implementation details of the one-shot method. My understanding was that it was originally supposed to be syntactic sugar on top of the "non-one shot" method. I was told by @kheradmandG that there's a difference now so I specified that it only applies to "one-shot only"
@smolkaj or @jonathan-dilorenzo do you have any context on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly correct @jafingerhut. This should be as easy as adding the same thing to the ActionProfileGroup proto.
We just don't have any use case (and don't actually support those at all I'm pretty sure) so we aimed to keep it simple by targeting only one piece.