Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to abseil symbolization / stack tracing routines #5077

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

asl
Copy link
Contributor

@asl asl commented Dec 26, 2024

This removes dependency on exeinfo and instead delegates platform-specific code to Abseil. The libbacktrace code is left intact as it provides slightly better information (file / line numbers when debug info is available), however, demangling there is switched to abseil::Symbolize is it does nice template type names filtering.

@asl asl requested review from vlstill, ChrisDodd and fruffy December 26, 2024 20:38
@asl
Copy link
Contributor Author

asl commented Dec 26, 2024

Example of Abseil's typename filtering during demangling:

allocated  80MB in 24992 calls from:
 ??: absl::lts_20240116::container_internal::raw_hash_set<>::insert<>() [100977894]
 ??: absl::lts_20240116::container_internal::raw_hash_set<>::find_or_prepare_insert<>() [100986820]
 ??: absl::lts_20240116::container_internal::raw_hash_set<>::prepare_insert() [100986910]
 ??: absl::lts_20240116::container_internal::raw_hash_set<>::resize() [100984fbc]

@asl asl added core Topics concerning the core segments of the compiler (frontend, midend, parser) run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. run-static Use this tag to trigger static build CI run. labels Dec 26, 2024
@ChrisDodd
Copy link
Contributor

Looks good overall -- I wasn't really happy with adding the dependence on abseil in the first place, but given we already have it.

Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
@asl asl enabled auto-merge January 7, 2025 03:20
@asl asl added this pull request to the merge queue Jan 7, 2025
Merged via the queue into p4lang:main with commit 80ef07c Jan 7, 2025
20 checks passed
@asl asl deleted the no-execinfo branch January 7, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser) run-static Use this tag to trigger static build CI run. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants