Don't apply defaultArguments in table action lists #4434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-defaultargs
branch
from
4a84ead to
f568d77
Compare
|
Could you add a test as an example of where this can happen? |
ChrisDodd
force-pushed
the
cdodd-defaultargs
branch
2 times, most recently
from
95f81da to
5ed7ca8
Compare
|
I added a testcase that triggers the BUG_CHECK I was seeing before with the previous code, but doesn't cover all the cases that should work with default args (because they still don't work). |
ChrisDodd
force-pushed
the
cdodd-defaultargs
branch
from
5ed7ca8 to
dcda7c6
Compare
fruffy
approved these changes
Feb 19, 2024
ChrisDodd
force-pushed
the
cdodd-defaultargs
branch
from
dcda7c6 to
ac5c551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When actions have default args, they should not be applied in the action list of a table, as the control plane may supply non-default values for these args.