[P4Testgen] Fix stringliteral conversion. Value must be a literal, NOT a constant #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
reviewed
Dec 19, 2023
backends/p4tools/modules/testgen/test/z3-solver/constraints.cpp
Outdated
Show resolved
Hide resolved
fruffy
force-pushed
the
fruffy/stringliteral_hotfix
branch
from
b324f96 to
a4f320b
Compare
fruffy
force-pushed
the
fruffy/stringliteral_hotfix
branch
from
a4f320b to
b1130c2
Compare
vlstill
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite the subtle issue I ran into. In the Z3 solver, string_constants are not constants but functions. We need to assign a value instead to get the correct semantic behavior. Otherwise, the solver can freely assign a value to the function.