Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4Testgen] Miscellaneous fixes for P4testgen #4036

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jun 16, 2023

  • Unify test numbering and the name of the variable in the test back ends. They all start from 0 now. Also make sure the test name does not have a duplicate ..
  • Provide hints on available test back ends.
  • Verify that no other packets are present if the packet is dropped in PTF.
  • Add some hints on the support Z3 versions. [P4Testgen] Control the Z3 dependency in CMake using fetchcontent, generalize FindZ3.cmake #4034 will fix this, too.
  • Support array indices when converting references.

Fixes #4033.

@fruffy fruffy requested review from pkotikal and jnfoster as code owners June 16, 2023 18:55
@fruffy fruffy changed the title Miscellaneous fixes for P4testgen [P4Testgen] Miscellaneous fixes for P4testgen Jun 16, 2023
@fruffy fruffy requested a review from jafingerhut June 16, 2023 18:55
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Jun 16, 2023
@fruffy fruffy force-pushed the fruffy/misc_issues branch from 63dc0d1 to 76fcb37 Compare June 16, 2023 19:34
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried out these changes and all the changes look like improvements to me. The PTF test generated still has classes named starting at 1, e.g. class Test1 up to class Test10 when generating 10 tests, instead of class Test0 up to class Test9.

Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy merged commit 894d572 into main Jun 19, 2023
@fruffy fruffy deleted the fruffy/misc_issues branch June 19, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with p4testgen back end
3 participants