Testgen: Switch cases can fall through. #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy-bfn
requested review from
fruffy,
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
hannelita
reviewed
Dec 5, 2022
| for (const auto* switchCase : switchStatement->cases) { | ||
| // Nothing to do with this statement, fall through to the next case. | ||
| // We have either matched already, or still need to match. | ||
| hasMatched = hasMatched || switchStatement->expression->equiv(*switchCase->label); |
There was a problem hiding this comment.
Sorry, I don't understand when exactly we'd be changing this flag, i.e. you are doing a reassignment on the LHS, but when we'd be turning that into true?
There was a problem hiding this comment.
If isMatched is false but the expression is equivalent to the label isMatched is set to true. After, all subsequent cases should also be executed until we hit a case that has a block statement.
vhavel
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testgen did not model the case where a switch case matches, but falls through to another case. This PR keeps track of a match boolean causes any downstream switch cases to be executed.