Bring commonly used builtin options under lib directory #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Jun 3, 2022
lib/options.cpp
Outdated
| compileCommand += argv[i]; | ||
| compileCommand += " "; | ||
| } | ||
| compileCommand = compileCommand.replace("(from pragmas)", ""); |
There was a problem hiding this comment.
Where is this coming from? Why does it apply to all backends?
There was a problem hiding this comment.
it is required here (dpdk backend) and other backend adopting from base code would need
and this information is available(first hand here).
There was a problem hiding this comment.
Where is the string "from pragmas" coming from?
There was a problem hiding this comment.
frontends/common/applyOptionsPragmas.cpp:30
There was a problem hiding this comment.
Wouldn't it be cleaner to just skip "(from pragmas)" only if it is argv[0]?
There was a problem hiding this comment.
yes skipped it.
kamleshbhalui
force-pushed
the
compile_commands_common
branch
from
c3b730c to
d569c8d
Compare
mihaibudiu
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.