Improvement of p4c-graphs backend #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… graphs graph_visitor -> class implementing functionality: - to create fullGraph in 'dot' format from boost graphs of program blocks - to create fullGraph in predefined 'json' format - to output separate graphs for each program block in 'dot' format (old functionality)
|
Please check the build failures. |
mihaibudiu
requested changes
Apr 29, 2022
| @@ -1,7 +1,9 @@ | |||
| # Graphs Backend | |||
|
|
|||
| This backend produces visual representations of a P4 program as dot files. For | |||
| now it only supports the generation of graphs for top-level control and parser blocks. | |||
| now it supports the generation of graphs for top-level control and parser blocks, | |||
| generation of fullGraph, which merges graphs for top-level program blocks and | |||
There was a problem hiding this comment.
what is really a "fullGraph"?
There was a problem hiding this comment.
It merges all generated boost graphs of parsers and control blocks into one graph.
This graph enables users to easily observe control flow of full program.
added program name to json output, fixed build errors
mihaibudiu
approved these changes
May 2, 2022
st22nestrel
added a commit
to st22nestrel/p4c
that referenced
this pull request
May 2, 2022
This reverts commit c6bd86f.
MichalKekely
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit c6bd86f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class Controls - added visiting of nodes with key and actions, which extends table node processing.
Class Parsers rewritten, so it now uses boost library for generation of graphs.
Created class Graph_visitor, which implements functionality to:
Updated Readme accordingly