Compile the P4 compiler tools in host configuration #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason I'm aware of to compile the compilers for the target architecture. As a side benefit, this may improve the build system's cache hit rate slightly because these tools don't need to be recompiled for Tsan/Asan/Msan/etc let alone x86 vs. ARM vs. etc. Signed-off-by: Chris Dolan <chrisdolan@google.com>
mihaibudiu
approved these changes
Mar 24, 2022
|
@mbudiu-vmw I'm happy to explain it further if it helps. But yes, it's pretty trivial. I tested on our copy with Clang's undefined-behavior sanitizer configured for the build -- without this change, the compiler itself is compiled with UBsan (incorrectly) and crashes but with this change the compiler is compiled optimized and runs normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason I'm aware of to compile the compilers for the target architecture.
As a side benefit, this may improve the build system's cache hit rate slightly because these tools don't need to be recompiled for Tsan/Asan/Msan/etc let alone x86 vs. ARM vs. etc.
Signed-off-by: Chris Dolan chrisdolan@google.com