Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pay more attention to types during constant folding #2338

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Pay more attention to types during constant folding #2338

merged 5 commits into from
Apr 27, 2020

Conversation

mihaibudiu
Copy link
Contributor

Fixes #2332

@jnfoster
Copy link
Contributor

Seems like e39a079 is not a part of this fix?

@mihaibudiu
Copy link
Contributor Author

I was hoping to merge that one first...
But I have to duplicate the work.

@mihaibudiu mihaibudiu merged commit d86cafa into p4lang:master Apr 27, 2020
@mihaibudiu mihaibudiu deleted the issue2332 branch April 27, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Untyped constant folding not sound
2 participants
@mihaibudiu @jnfoster