Setting specific priority queue depth or rate #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to set the depth or rate of priority queues in the simple switch. At the moment the
sswitch_CLI.py
is usingset_egress_queue_depth/rate
to set the rate/depth of a given port but there was not way to set if for an individual priority queue.This patch adds:
set_egress_priority_queue_depth/rate
in thesimple_switch
implementationthrift
filesdo_set_queue_depth/rate
fromsswitch_CLI.py
so they call the new functions when a priority is provided. Also added exception catchers when the parameters are not integers.Update: I realized that this will not build if the
multiqueueing
is not enabled at compile time. This is becauseQueueingLogicRL
does not know about priorities. What would be the right way to proceed?