Miscellaneous patches #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
reviewed
Jul 18, 2023
lightning/src/util/events.rs
Outdated
| @@ -462,7 +462,9 @@ pub enum BumpTransactionEvent { | |||
| /// [`BaseSign::sign_holder_htlc_transaction`]: crate::chain::keysinterface::BaseSign::sign_holder_htlc_transaction | |||
| /// [`HTLCDescriptor::tx_input_witness`]: HTLCDescriptor::tx_input_witness | |||
| HTLCResolution { | |||
| /// | |||
In order to avoid an `unwrap` when building `ChannelDetails`.
Not super important because we are not currently relying on these tests, but it's always easier to develop if all the code builds.
Tibo-lg
approved these changes
Jul 19, 2023
Tibo-lg
pushed a commit
that referenced
this pull request
Aug 22, 2023
The amount for HTLC #6 was updated in the spec's test vectors, but the "same amount and preimage" test vector itself was not updated, even though the new HTLC amount resulted in a different commitment transaction, and thus, different signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for 38c54c5, ab73cce and 40bd0c4 is to be able to use the async background processor without problems. These bug fixes are part of 0.0.115.
40bd0c4 is useful because the disconnects are important for debugging at the moment, but TRACE-level logs are too noisy in that module.
d6e4ba8 is not so important so we could drop it, but it's also very simple so it can't hurt.
b4e4eb0 might be the most controversial, but we did run into a related
unwrapa few times, so it seemed like a good idea at the time.