Create ContractSignerProvider

[benthecarman]

Closes #185

Still some cleanup to do but curious on direction here. Tried to mimic LDK's trait as best I could.

Instead of creating a create_adoptor_signature function I went with just get_secret_key as this would be really invasive and require refactor things in other crates that weren't just dlc_manager. Also kept the old functions around for the channel handling, a lot of that I don't fully know what is going on and this felt simpler for now.

[Tibo-lg]

Just had a quick look but the overall direction matches with what I had in mind. I feel it might be better to keep the signers in memory though (and maybe have the lazily created) rather than re-deriving them every time they are needed.

[benthecarman]

Added a cache and reworked some the APIs to be cleaner, think tests should be passing now too.

[benthecarman]

Got pretty much everything passing and in a clean state. Only test failing is pnl_compute_test because the serialization of OfferedContract changed. Is there an easy way to generate a new AcceptedContract for this test?

[Tibo-lg]

Is there an easy way to generate a new AcceptedContract for this test?

Have you tried using the one within dlc-sled-storage-provider/test_files? If it works maybe it'd be best to just use that directly (update the path).

[benthecarman]

Is there an easy way to generate a new AcceptedContract for this test?

Have you tried using the one within dlc-sled-storage-provider/test_files? If it works maybe it'd be best to just use that directly (update the path).

Does not work either, I imagine all of those tests are broken too :/

[Tibo-lg]

Is there an easy way to generate a new AcceptedContract for this test?

Have you tried using the one within dlc-sled-storage-provider/test_files? If it works maybe it'd be best to just use that directly (update the path).

Does not work either, I imagine all of those tests are broken too :/

Ah these ones can be generated with this script: 'scripts/generate_serialized_contract_files.sh'.

[benthecarman]

Regenerated test vectors and everything seems to pass now :)

[Tibo-lg]

Overall looks nice, but still some details to be resolved.

[Tibo-lg]

I feel like this method should take more parameters, like maybe the collateral values, the event id, or whatever could be use to generate a likely unique key id. Then IIUC this should be called only once, so if using the method I mention below, you could check that the label does not exist (and maybe panic if it does?)

[benthecarman]

A lot of the parameters aren't really always available. The main problems comes from renew_offer where you have to do it from only a single party's params

[Tibo-lg]

This will probably need to be split in the future, but fine if you don't do it now.

[benthecarman]

Think I responded to all comments

[Tibo-lg]

Thanks, just a couple of things need fixing.

[Tibo-lg]

Thanks!