Update version #66
Open
Update version #66
+190
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yancyribbens
force-pushed
the
update-api
branch
from
99effaf
to
19b07b0
Compare
yancyribbens
force-pushed
the
update-api
branch
from
19b07b0
to
b13e7a1
Compare
If no results are found, the API as documented returns None. However, if a target amount of zero is passed, the API returned an empty vec wrapped in an Option type. This commit changes the behavior of a target amount of zero to return None in keeping with the API as documented.
yancyribbens
force-pushed
the
update-api
branch
from
b13e7a1
to
e0a8be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of cleanup commits, and also a minor API bug found while running prop tests. If zero is passed as the target amount, the API returns an empty vec, however as it's currently documented, it should return None on no match found.