Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare README for v0.5.0 release #532

Merged
merged 38 commits into from
Aug 31, 2023
Merged

Prepare README for v0.5.0 release #532

merged 38 commits into from
Aug 31, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Aug 25, 2023

Closes: #526

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b032092) 92.19% compared to head (18ac930) 92.19%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         102      102           
  Lines       16108    16108           
=======================================
  Hits        14850    14850           
  Misses       1258     1258           
Files Changed Coverage Δ
aquadoggo/src/lib.rs 85.71% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha changed the title Update READMEs Prepare README for v0.5.0 release Aug 25, 2023
@adzialocha adzialocha marked this pull request as ready for review August 30, 2023 19:11
@adzialocha
Copy link
Member Author

This looks really amazing to me now! Thank you @sandreae for all of these good ideas for the README.

@adzialocha
Copy link
Member Author

Screenshot_20230831-093741_GitHub.png

This I stumbled upon, what do you think? It's right at the beginning but directly diverges to other projects, I think that can be a bit confusing (people want to get started with aquadoggo and not with fishy)? Could the section just move down, or at least somehow the links part?

@sandreae
Copy link
Member

Yeh, totally agree that it's weird to link out to other resources right away. I had the idea to add a new section near the end of the README titled Resources and here we can list fishy, send-to-node, tutorials etc... Then we don't need to link to them directly in the section you highlighted.

@sandreae
Copy link
Member

I also want to add a section showing some GraphQL query examples.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sandreae
Copy link
Member

I'm really happy with it now!! Added a section on the query API and resources, made a few changes in other sections which I think improved clarity.

@sandreae
Copy link
Member

Only thing I'm not sure about is that maybe the aquadoggo/README.md should have more stuff in it, or at least a clear link back to the main repo README.

@sandreae
Copy link
Member

Aaaaaand actually I recon we need to beef up our doc strings in lib.rs, they still contain something very similar to the old README.

@sandreae
Copy link
Member

Aaaaaand actually I recon we need to beef up our doc strings in lib.rs, they still contain something very similar to the old README.

We can include the README there like this: #![doc = include_str!("../README.md")]

@sandreae
Copy link
Member

Oh, that's pretty cool, examples in the included README are also run during tests (although it fails right now).

@sandreae
Copy link
Member

Oh, that's pretty cool, examples in the included README are also run during tests (although it fails right now).

I had do disable this feature for now cos there is required code setup which we can't do in the README 😅

@sandreae sandreae merged commit c9882d0 into main Aug 31, 2023
9 of 10 checks passed
@sandreae sandreae deleted the update-readme-release branch August 31, 2023 16:54
adzialocha added a commit that referenced this pull request Sep 6, 2023
* main:
  Minor README.md updates
  0.5.0
  Prepare README for v0.5.0 release (#532)
  Set unix cfg correctly
  Do only set permissions mode on unix
  Update RELEASE.md
  Improve log level user interface (#539)
  Move deserialization into `PeerMessage` to distinct variants correctly (#538)
  Bring back all connection handler logs to warn level again
  Add compiling windows binaries as well, remove macos universal one
  Adjust release profile
  Add checksum when releasing binaries
  Add v0.5.0 to CHANGELOG.md
  Add armv7-unknown-linux-gnueabihf target for cross compilation CI
  Add CI to compile and publish releases
  Make clippy happy
  Convert to ip addresses when logging multiaddr on info level
  Increase log level of handler errors to trace-level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a nice usage section for aquadoggo command line app
2 participants