Add test coverage for PathAccessor and FilesystemPath OSError handling #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting test coverage for
PathAccessorandFilesystemPathto prevent regressions in filesystem behavior changes.Changes
New test file
tests/unit/test_filesystem.pywith 23 tests covering:PathAccessor.stat()returningNoneonOSError(nonexistent paths, permission errors)PathAccessor.keys()returning entry names not full pathslstat()on Python <3.10 andstat(follow_symlinks=False)on ≥3.10FilesystemPath.exists()behavior delegating tostat()resultTest assertions verify:
keys()returns["file.txt"]not["/full/path/file.txt"]stat()on symlinks returns symlink's own stat (size ≠ target size)exists()returnsFalsewhenstat()raisesOSErrorExample
Coverage improved from 48% to 87%. Added
reports/to.gitignoreto exclude test artifacts.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.