Garbled characters in serial output

[p14c31355]

Overview

Environment of occurrence

• Target: Arduino Uno
• HAL or MCU: ATmega328p
• OS/Build Tool: Ravedude
• no_std: true
• Feature Flags: e-hal_0_2

Reproduction procedure

#![no_std]
#![no_main]

use core::fmt::Write;
use dvcdbg::explore::explorer::{CmdNode, Explorer};
use dvcdbg::explore::logger::{LogLevel, SerialLogger};
use dvcdbg::prelude::*;
use panic_abort as _;
adapt_serial!(UnoWrapper);

const BUF_CAP: usize = 128;

#[arduino_hal::entry]
fn main() -> ! {
    let dp = arduino_hal::Peripherals::take().unwrap();
    let pins = arduino_hal::pins!(dp);

    let mut serial = UnoWrapper(arduino_hal::default_serial!(dp, pins, 9600));
    arduino_hal::delay_ms(1000);

    let mut logger: SerialLogger<'_, _, BUF_CAP> = SerialLogger::new(&mut serial, LogLevel::Quiet);

    let mut i2c = arduino_hal::I2c::new(
        dp.TWI,
        pins.a4.into_pull_up_input(),
        pins.a5.into_pull_up_input(),
        100_000,
    );
    const INIT_SEQUENCE: [u8; 26] = [
        0xAE, 0xD5, 0x51, 0xA8, 0x3F, 0xD3, 0x60, 0x40, 0x00, 0xA1, 0x00, 0xA0, 0xC8, 0xAD, 0x8A,
        0xD9, 0x22, 0xDB, 0x35, 0x8D, 0x14, 0xB0, 0x00, 0x10, 0xA6, 0xAF,
    ];



    static EXPLORER_CMDS: [CmdNode; 17] = [
        CmdNode {
            bytes: &[0xAE],
            deps: &[],
        },
        CmdNode {
            bytes: &[0xD5, 0x51],
            deps: &[0],
        },
        CmdNode {
            bytes: &[0xA8, 0x3F],
            deps: &[1],
        },
        CmdNode {
            bytes: &[0xD3, 0x60],
            deps: &[2],
        },
        CmdNode {
            bytes: &[0x40, 0x00],
            deps: &[3],
        },
        CmdNode {
            bytes: &[0xA1, 0x00],
            deps: &[4],
        },
        CmdNode {
            bytes: &[0xA0],
            deps: &[5],
        },
        CmdNode {
            bytes: &[0xC8],
            deps: &[6],
        },
        CmdNode {
            bytes: &[0xAD, 0x8A],
            deps: &[7],
        },
        CmdNode {
            bytes: &[0xD9, 0x22],
            deps: &[8],
        },
        CmdNode {
            bytes: &[0xDB, 0x35],
            deps: &[9],
        },
        CmdNode {
            bytes: &[0x8D, 0x14],
            deps: &[10],
        },
        CmdNode {
            bytes: &[0xB0],
            deps: &[11],
        },
        CmdNode {
            bytes: &[0x00],
            deps: &[11],
        },
        CmdNode {
            bytes: &[0x10],
            deps: &[11],
        },
        CmdNode {
            bytes: &[0xA6],
            deps: &[12, 13, 14],
        },
        CmdNode {
            bytes: &[0xAF],
            deps: &[15],
        },
    ];

    let explorer: Explorer<'_, 17> = Explorer {
        sequence: &EXPLORER_CMDS,
    };
    let prefix: u8 = 0x00;

    let successful_seq = match dvcdbg::scanner::scan_init_sequence(
        &mut i2c,
        &mut logger,
        prefix,
        &INIT_SEQUENCE,
        LogLevel::Verbose,
    ) {
        Ok(seq) => seq,
        Err(e) => {
            logger.log_error_fmt(|buf| {
                write!(
                    buf,
                    "[error] Initial sequence scan failed: {e:?}. Aborting explorer."
                )
            });
            panic!("Initial sequence scan failed.");
        }
    };
    logger.log_info_fmt(|buf| write!(buf, "[log] Start driver safe init"));

    let mut executor = dvcdbg::explore::explorer::PrefixExecutor::<BUF_CAP>::new(prefix, successful_seq);
    const MAX_CMD_LEN: usize = 3;

    match dvcdbg::explore::runner::run_pruned_explorer::<_, _, _, 17, BUF_CAP, MAX_CMD_LEN>(
        &explorer,
        &mut i2c,
        &mut executor,
        &mut logger,
        prefix,
        LogLevel::Quiet,
    ) {
        Ok(_) => logger.log_info_fmt(|buf| write!(buf, "[I] Explorer OK.")),
        Err(e) => {
            logger.log_error_fmt(|buf| write!(buf, "[E] Explorer failed: {:?}\r\n", e));
        }
    }
    logger.log_info_fmt(|buf| write!(buf, "[D] Enter main loop."));
    loop {
        arduino_hal::delay_ms(1000);
    }
}

Expected behaviour

No garbled

Actual behaviour

  Programmed target/avr-none/debug/main.elf
     Console /dev/ttyACM0 at 9600 baud
             CTRL+C to exit.

[scan] Scanning I2C bus with init sequence:
 9�>�JJ�
        &�"5?@Q`���������������AF��*|�J� na����J� �>�JJ�
                                                        &��Q�?�`@��ȭ��"�5����� Ente�mait��p   <80   IrO2d2W+�(%6#9%6,�R6� �A�HBIr���H�06IFl
���c]0xR6@��

OutOfRangeArbi�ccstBusModeFaultI2cSpiAdcHardwareUnderrunOverflowI2cError bytes: 


BufferInvalidConfigUnknownOtherInvalidStateFramingParityOverrunTimeoutUnderflowExecFailedBufferOverflowTooManyCommandsDependencyCycleNoValidAddressesFoundExecutionFailedInvalidDependencyIndexDeviceNotFoundPowerPeripheralShortCircuitOpenCircuit �[error] Failed to generate a new topological sort: . Aborting.
�3
  [I2C retry error] 06[explorer] FAILED: J6[explorer] Sending node  ...
e} � �[explorer] OK
�[log] Scanning 0x�...� Found
�!6 No response (NACK)
�[warn] Missing commands buffer is full, list is truncated.
�;Expected sequence:
>6Commands with response:
YCommands with no response:
ucan] Scanning I2C bus with init sequence:
�,[info] I2C scan with init sequence complete.
�-[ok] Found device at � responded to 0x
[error] scan failed for command 0x#"[log] Scanning I2C bus...
�5#J#*$�-$1$g%�4%=%m��Q�?�`@��ȭ��"�5������Q�?�`�ȭ��"�5���
�����w�{}�����y����������x�������[error] Initial sequence scan failed: . Aborting explorer.J&p[log] Start driver safe init�[I] Explorer OK.�[E] Explorer failed: 
��[D] Enter main loop.����#)�0*��)[: �.�/0, ,
((

]0x000102030405060708091011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798IHFM6 HWP4%"""<<0""""""""""""""0�""""""5"""�"""""""""""""""""""""""""""""""""""""""""""""""""H���"""�"""""""""""""""""""""""""""""""""""""""""""""""""""""""""2d2W+�(%6#9%6,�R6� �A�HBIr���H�06IFl
���c]0xR6@��

OutOfRangeArbi�ccstBusModeFaultI2cSpiAdcHardwareUnderrunOverflowI2cError bytes: 


BufferInvalidConfigUnknownOtherInvalidStateFramingParityOverrunTimeoutUnderflowExecFailedBufferOverflowTooManyCommandsDependencyCycleNoValidAddressesFoundExecutionFailedInvalidDependencyIndexDeviceNotFoundPowerPeripheralShortCircuitOpenCircuit �[error] Failed to generate a new topological sort: . Aborting.
�3
  [I2C retry error] 06[explorer] FAILED: J6[explorer] Sending node  ...
e} � �[explorer] OK
�[log] Scanning 0x�...� Found
�!6 No response (NACK)
�[warn] Missing commands buffer is full, list is truncated.
�;Expected sequence:
>6Commands with response:
YCommands with no response:
ucan] Scanning I2C bus with init sequence:
�,[info] I2C scan with init sequence complete.
�-[ok] Found device at � responded to 0x
[error] scan failed for command 0x#"[log] Scanning I2C bus...
�5#J#*$�-$1$g%�4%=%m��Q�?�`@��ȭ��"�5������Q�?�`�ȭ��"�5���
�����w�{}�����y����������x�������[error] Initial sequence scan failed: . Aborting explorer.J&p[log] Start driver safe init�[I] Explorer OK.�[E] Explorer failed: 
��[D] Enter main loop.�����

---