Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to check run-time version of the library #637

Merged
merged 1 commit into from
May 9, 2024

Conversation

ueno
Copy link
Member

@ueno ueno commented May 7, 2024

This adds p11_kit_check_version function, which can be used to check the run-time version of p11-kit.

Fixes: #523

@ueno ueno requested a review from ZoltanFridrich May 9, 2024 06:35
@ueno ueno force-pushed the wip/dueno/version-api2 branch 2 times, most recently from 3f1f148 to ad250d8 Compare May 9, 2024 08:16
@coveralls
Copy link

coveralls commented May 9, 2024

Coverage Status

coverage: 69.537% (-0.02%) from 69.556%
when pulling f3a39ad on ueno:wip/dueno/version-api2
into 652927d on p11-glue:master.

p11-kit/util.c Outdated Show resolved Hide resolved
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This adds p11_kit_check_version function, which can be used to check
the run-time version of p11-kit.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
@ueno
Copy link
Member Author

ueno commented May 9, 2024

Thanks for the review!

@ueno ueno merged commit e4cf037 into p11-glue:master May 9, 2024
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.4 milestone Jul 1, 2024
@ametzler
Copy link

ametzler commented Jul 6, 2024

Looking at 0.25.5 p11_kit_check_version() is part of the source but afaict it is dead code. version.h with the function prototype is not installed and the function is not part of the exported API either since it is not listed in p11-kit/libp11-kit.map.

ueno added a commit to ueno/p11-kit that referenced this pull request Jul 7, 2024
Previously, version.h was not installed when building with Autotools,
and the function symbol was not exposed from libp11-kit when building
with Meson.

Reported by Andreas Metzler in:
p11-glue#637 (comment)

Signed-off-by: Daiki Ueno <ueno@gnu.org>
@ueno
Copy link
Member Author

ueno commented Jul 7, 2024

@ametzler indeed; thank you for the report. Could you check #648?

ueno added a commit to ueno/p11-kit that referenced this pull request Jul 7, 2024
Previously, version.h was not installed when building with Autotools,
and the function symbol was not exposed from libp11-kit when building
with Meson.

Reported by Andreas Metzler in:
p11-glue#637 (comment)

Signed-off-by: Daiki Ueno <ueno@gnu.org>
ueno added a commit to ueno/p11-kit that referenced this pull request Jul 7, 2024
Previously, version.h was not installed when building with Autotools,
and the function symbol was not exposed from libp11-kit when building
with Meson.

Reported by Andreas Metzler in:
p11-glue#637 (comment)

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: API for getting the code version.
4 participants