Skip to content

Commit

Permalink
rename exe_runner to exe_wrapper everywhere
Browse files Browse the repository at this point in the history
I don't understand the purpose of this confusing API naming split.
  • Loading branch information
eli-schwartz committed Dec 5, 2021
1 parent 4b2c545 commit 5b7d4f8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
6 changes: 3 additions & 3 deletions mesonbuild/backend/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def __init__(self, cmd_args: T.List[str],
self.env = env
if exe_wrapper is not None:
assert isinstance(exe_wrapper, programs.ExternalProgram)
self.exe_runner = exe_wrapper
self.exe_wrapper = exe_wrapper
self.workdir = workdir
self.extra_paths = extra_paths
self.capture = capture
Expand All @@ -229,7 +229,7 @@ def __init__(self, name: str, project: str, suite: T.List[str], fname: T.List[st
self.is_cross_built = is_cross_built
if exe_wrapper is not None:
assert isinstance(exe_wrapper, programs.ExternalProgram)
self.exe_runner = exe_wrapper
self.exe_wrapper = exe_wrapper
self.is_parallel = is_parallel
self.cmd_args = cmd_args
self.env = env
Expand Down Expand Up @@ -617,7 +617,7 @@ def as_meson_exe_cmdline(self, exe: T.Union[str, mesonlib.File, build.BuildTarge
if es.extra_paths:
reasons.append('to set PATH')

if es.exe_runner:
if es.exe_wrapper:
reasons.append('to use exe_wrapper')

if workdir:
Expand Down
12 changes: 6 additions & 6 deletions mesonbuild/mtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1350,18 +1350,18 @@ def _get_test_cmd(self) -> T.Optional[T.List[str]]:
elif not self.test.is_cross_built and run_with_mono(self.test.fname[0]):
return ['mono'] + self.test.fname
elif self.test.cmd_is_built and self.test.is_cross_built and self.test.needs_exe_wrapper:
if self.test.exe_runner is None:
if self.test.exe_wrapper is None:
# Can not run test on cross compiled executable
# because there is no execute wrapper.
return None
elif self.test.cmd_is_built:
# If the command is not built (ie, its a python script),
# then we don't check for the exe-wrapper
if not self.test.exe_runner.found():
if not self.test.exe_wrapper.found():
msg = ('The exe_wrapper defined in the cross file {!r} was not '
'found. Please check the command and/or add it to PATH.')
raise TestException(msg.format(self.test.exe_runner.name))
return self.test.exe_runner.get_command() + self.test.fname
raise TestException(msg.format(self.test.exe_wrapper.name))
return self.test.exe_wrapper.get_command() + self.test.fname
return self.test.fname

def _get_cmd(self) -> T.Optional[T.List[str]]:
Expand Down Expand Up @@ -1575,8 +1575,8 @@ def get_test_runner(self, test: TestSerialisation) -> SingleTestRunner:
test_env = test.env.get_env(env)
env.update(test_env)
if (test.is_cross_built and test.needs_exe_wrapper and
test.exe_runner and test.exe_runner.found()):
env['MESON_EXE_WRAPPER'] = join_args(test.exe_runner.get_command())
test.exe_wrapper and test.exe_wrapper.found()):
env['MESON_EXE_WRAPPER'] = join_args(test.exe_wrapper.get_command())
return SingleTestRunner(test, env, name, options)

def process_test_result(self, result: TestRun) -> None:
Expand Down
12 changes: 6 additions & 6 deletions mesonbuild/scripts/meson_exe.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ def buildparser() -> argparse.ArgumentParser:
return parser

def run_exe(exe: ExecutableSerialisation, extra_env: T.Optional[T.Dict[str, str]] = None) -> int:
if exe.exe_runner:
if not exe.exe_runner.found():
if exe.exe_wrapper:
if not exe.exe_wrapper.found():
raise AssertionError('BUG: Can\'t run cross-compiled exe {!r} with not-found '
'wrapper {!r}'.format(exe.cmd_args[0], exe.exe_runner.get_path()))
cmd_args = exe.exe_runner.get_command() + exe.cmd_args
'wrapper {!r}'.format(exe.cmd_args[0], exe.exe_wrapper.get_path()))
cmd_args = exe.exe_wrapper.get_command() + exe.cmd_args
else:
cmd_args = exe.cmd_args
child_env = os.environ.copy()
Expand All @@ -48,9 +48,9 @@ def run_exe(exe: ExecutableSerialisation, extra_env: T.Optional[T.Dict[str, str]
if exe.extra_paths:
child_env['PATH'] = (os.pathsep.join(exe.extra_paths + ['']) +
child_env['PATH'])
if exe.exe_runner and mesonlib.substring_is_in_list('wine', exe.exe_runner.get_command()):
if exe.exe_wrapper and mesonlib.substring_is_in_list('wine', exe.exe_wrapper.get_command()):
child_env['WINEPATH'] = mesonlib.get_wine_shortpath(
exe.exe_runner.get_command(),
exe.exe_wrapper.get_command(),
['Z:' + p for p in exe.extra_paths] + child_env.get('WINEPATH', '').split(';')
)

Expand Down

0 comments on commit 5b7d4f8

Please sign in to comment.