Table: Provide size() function returning row counts #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a function returning the number of rows is useful for me - I can format the table's rows at once after the table is built according to the number of rows, instead of setting a counter aside. I also saw that the
size()
function is already provided inTableInternal
, so I think just returning the return value oftable_->size()
is fine.Since there is no test, here's the testing code that I used to test the feature after I implemented it:
Also runs
clang-format
script intable.hpp
file.