Add JSON support for formatting output data #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @btaczala. Thanks for the PR. I like the idea and I want to merge it. I've made some minor suggestions (style related) and asked a few questions. Once these are resolved, we can merge. Thanks. |
|
@p-ranav I don't see any suggestions and questions in code review. Or maybe I'm missing something? |
p-ranav
requested changes
May 13, 2022
p-ranav
approved these changes
May 27, 2022
galexite
added a commit
to galexite/fccf
that referenced
this pull request
Oct 20, 2024
Link against `libclang` as imported from the `Clang` CMake package, instead of linking every LLVM library written out by `llvm-config --libs all`. This also happens to fix p-ranav#14 and p-ranav#7, as it lets CMake find and require the `Clang` package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds JSON support for formatting results. I'd like to hook fccf into other tools (neovim) and it's much easier to parse JSON that plain text.
This adds a 3rdParty dependency (awesome nlohmann json library) - hope you won't mind.