fix hostname params and add full-disable params(chaos-mesh#226)

ozontech-forks · Jan 16, 2023 · 773e322 · 773e322
1 parent a9c0540
commit 773e322
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/cmd/attack/network.go b/cmd/attack/network.go
@@ -114,6 +114,7 @@ func NewNetworkLossCommand(dep fx.Option, options *core.NetworkCommand) *cobra.C
 	cmd.Flags().StringVarP(&options.Hostname, "hostname", "H", "", "only impact traffic to these hostnames")
 	cmd.Flags().StringVarP(&options.IPProtocol, "protocol", "p", "",
 		"only impact traffic using this IP protocol, supported: tcp, udp, icmp, all")
+	cmd.Flags().BoolVar(&options.FullDisable, "full-disable", false, "full net on device disable flag")
 
 	return cmd
 }

diff --git a/pkg/core/network.go b/pkg/core/network.go
@@ -43,7 +43,8 @@ type NetworkCommand struct {
 	IPProtocol  string `json:"ip-protocol,omitempty"`
 	Hostname    string `json:"hostname,omitempty"`
 
-	Direction string `json:"direction,omitempty"`
+	Direction   string `json:"direction,omitempty"`
+	FullDisable bool   `json:"full-disable,omitempty"`
 
 	// used for DNS attack
 	DNSServer     string `json:"dns-server,omitempty"`
@@ -174,6 +175,16 @@ func (n *NetworkCommand) validNetworkCommon() error {
 		return errors.Errorf("ip addressed %s not valid", n.IPAddress)
 	}
 
+	if len(n.Hostname) == 0 && len(n.IPAddress) == 0 && !n.FullDisable {
+		return errors.New("hostname or ip address is required")
+	}
+
+	if n.FullDisable {
+		if len(n.Hostname) > 0 || len(n.IPAddress) > 0 {
+			return errors.New("the host and address are set, but the flag full-disable is enabled")
+		}
+	}
+
 	return checkProtocolAndPorts(n.IPProtocol, n.SourcePort, n.EgressPort)
 }