Skip to content

Commit

Permalink
Fixed culture specific serialization issue of float and double.
Browse files Browse the repository at this point in the history
Delimiter was removed when serializing a float or a double.
For example: 10.12 ended up as 1012.
  • Loading branch information
jorlokk committed Aug 21, 2011
1 parent 7d0eac3 commit 57fcff5
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
24 changes: 24 additions & 0 deletions Rhino.ServiceBus.Tests/XmlSerializerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,30 @@ public void Can_serialize_and_deserialize_primitive()
Assert.Equal(ticks, actual);
}

[Fact]
public void Can_serialize_and_deserialize_double()
{
double aDouble = 1.12;
var serializer = new XmlMessageSerializer(new DefaultReflection(), new CastleServiceLocator(new WindsorContainer()));
var stream = new MemoryStream();
serializer.Serialize(new object[] { aDouble }, stream);
stream.Position = 0;
var actual = (double)serializer.Deserialize(stream)[0];
Assert.Equal(aDouble, actual);
}

[Fact]
public void Can_serialize_and_deserialize_float()
{
float aFloat = 1.12f;
var serializer = new XmlMessageSerializer(new DefaultReflection(), new CastleServiceLocator(new WindsorContainer()));
var stream = new MemoryStream();
serializer.Serialize(new object[] { aFloat }, stream);
stream.Position = 0;
var actual = (float)serializer.Deserialize(stream)[0];
Assert.Equal(aFloat, actual);
}

[Fact]
public void Can_serialize_and_deserialize_byte_array()
{
Expand Down
8 changes: 7 additions & 1 deletion Rhino.ServiceBus/Serializers/XmlMessageSerializer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,13 @@ private static string FormatAsString(object value)

if (value is decimal)
return ((decimal) value).ToString(CultureInfo.InvariantCulture);


if (value is double)
return ((double)value).ToString(CultureInfo.InvariantCulture);

if (value is float)
return ((float)value).ToString(CultureInfo.InvariantCulture);

return value.ToString();
}

Expand Down

0 comments on commit 57fcff5

Please sign in to comment.