Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Conversation

@andrey-legayev
Copy link

Hi,

I've run xdebug profiler for Magento2 static content deploy and found huge amount of calls to in_array()
I've tried to optimize it and got ~4% performance improvement.

Pls review my changes.

Andrey

@andrey-legayev
Copy link
Author

It looks like travis config is outdated... PHP versions are not supported anymore

@andrey-legayev
Copy link
Author

andrey-legayev commented Sep 25, 2019

Travis conf updated. All unit tests are passed.

@hostep
Copy link

hostep commented Sep 26, 2019

@andrey-legayev: great job!

However, Magento2 is no longer going to use this original less.php library, they'll be moving to a different fork: https://github.com/wikimedia/less.php/ in Magento 2.3.3 and higher (see magento/magento2@9a4332c).
That last one is better maintained then this original fork and has support for PHP 7.3 which Magento 2.3.3 needs.

So you'd best also send the same PR to the wikimedia fork :)

@andrey-legayev
Copy link
Author

Thanks, I'll check it out

@andrey-legayev
Copy link
Author

Submitted to Wikimedia fork: wikimedia#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants