-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tflint #3594
Upgrade tflint #3594
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ API | spectral | 2 | 0 | 3.7s | |
✅ BASH | bash-exec | 5 | 0 | 0.08s | |
✅ BASH | shellcheck | 5 | 0 | 0.15s | |
✅ BASH | shfmt | 5 | 0 | 0 | 0.63s |
✅ COPYPASTE | jscpd | yes | no | 4.84s | |
✅ DOCKERFILE | hadolint | 129 | 0 | 20.51s | |
✅ JSON | jsonlint | 18 | 0 | 0.32s | |
✅ JSON | v8r | 20 | 0 | 34.95s | |
markdownlint | 264 | 0 | 270 | 48.44s | |
✅ MARKDOWN | markdown-table-formatter | 264 | 0 | 0 | 155.81s |
✅ OPENAPI | spectral | 2 | 0 | 3.61s | |
bandit | 210 | 64 | 4.78s | ||
✅ PYTHON | black | 210 | 0 | 0 | 6.45s |
✅ PYTHON | flake8 | 210 | 0 | 3.05s | |
✅ PYTHON | isort | 210 | 0 | 0 | 1.36s |
✅ PYTHON | mypy | 210 | 0 | 22.62s | |
✅ PYTHON | pylint | 210 | 0 | 21.97s | |
✅ PYTHON | ruff | 210 | 0 | 0 | 0.78s |
✅ REPOSITORY | checkov | yes | no | 51.28s | |
✅ REPOSITORY | git_diff | yes | no | 0.67s | |
grype | yes | 1 | 28.18s | ||
✅ REPOSITORY | secretlint | yes | no | 21.5s | |
✅ REPOSITORY | trivy | yes | no | 34.07s | |
✅ REPOSITORY | trivy-sbom | yes | no | 11.97s | |
trufflehog | yes | 1 | 14.91s | ||
✅ SPELL | cspell | 689 | 0 | 36.85s | |
lychee | 344 | 5 | 8.16s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0.73s |
✅ YAML | prettier | 161 | 0 | 0 | 7.19s |
✅ YAML | v8r | 102 | 0 | 232.53s | |
✅ YAML | yamllint | 162 | 0 | 2.45s |
See detailed report in MegaLinter reports
I'd prefer another naming convention for easier integration next week with renovate. Simply the tool name (uppercase), underscore, and VERSION. It is quite standard across projects, and will not put us on our own as we follow a pattern that others use. Take a look at this commit: echoix@fcaa24f And the resulting renovate PR: https://github.com/echoix/megalinter/pull/53/files (it updates the descriptor as well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@echoix changed :) |
@@ -44,7 +45,7 @@ FROM checkmarx/kics:alpine as kics | |||
FROM trufflesecurity/trufflehog:latest as trufflehog | |||
FROM jdkato/vale:latest as vale | |||
FROM lycheeverse/lychee:latest-alpine as lychee | |||
FROM ghcr.io/terraform-linters/tflint:v0.51.0 as tflint | |||
FROM ghcr.io/terraform-linters/tflint:v${TFLINT_VERSION} as tflint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but maybe I'll have to include the v inside the env var. And anyways, if someone wants to use the variable to point to a different tag, that restricts to tags starting with v
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep SEMVER values for versions ^^
@echoix i merged coz i'd like to make a new release today, but we can make updates, like maybe an intermediate variable with docker image name that would be calculated from version semver if not overridden :) |
No description provided.