Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tflint #3594

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Upgrade tflint #3594

merged 5 commits into from
Jun 2, 2024

Conversation

nvuillam
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented May 29, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 2 0 3.7s
✅ BASH bash-exec 5 0 0.08s
✅ BASH shellcheck 5 0 0.15s
✅ BASH shfmt 5 0 0 0.63s
✅ COPYPASTE jscpd yes no 4.84s
✅ DOCKERFILE hadolint 129 0 20.51s
✅ JSON jsonlint 18 0 0.32s
✅ JSON v8r 20 0 34.95s
⚠️ MARKDOWN markdownlint 264 0 270 48.44s
✅ MARKDOWN markdown-table-formatter 264 0 0 155.81s
✅ OPENAPI spectral 2 0 3.61s
⚠️ PYTHON bandit 210 64 4.78s
✅ PYTHON black 210 0 0 6.45s
✅ PYTHON flake8 210 0 3.05s
✅ PYTHON isort 210 0 0 1.36s
✅ PYTHON mypy 210 0 22.62s
✅ PYTHON pylint 210 0 21.97s
✅ PYTHON ruff 210 0 0 0.78s
✅ REPOSITORY checkov yes no 51.28s
✅ REPOSITORY git_diff yes no 0.67s
⚠️ REPOSITORY grype yes 1 28.18s
✅ REPOSITORY secretlint yes no 21.5s
✅ REPOSITORY trivy yes no 34.07s
✅ REPOSITORY trivy-sbom yes no 11.97s
⚠️ REPOSITORY trufflehog yes 1 14.91s
✅ SPELL cspell 689 0 36.85s
⚠️ SPELL lychee 344 5 8.16s
✅ XML xmllint 3 0 0 0.73s
✅ YAML prettier 161 0 0 7.19s
✅ YAML v8r 102 0 232.53s
✅ YAML yamllint 162 0 2.45s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented May 30, 2024

I'd prefer another naming convention for easier integration next week with renovate.

Simply the tool name (uppercase), underscore, and VERSION. It is quite standard across projects, and will not put us on our own as we follow a pattern that others use.

Take a look at this commit: echoix@fcaa24f

And the resulting renovate PR: https://github.com/echoix/megalinter/pull/53/files (it updates the descriptor as well)

Copy link
Collaborator

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@nvuillam
Copy link
Member Author

nvuillam commented Jun 2, 2024

@echoix changed :)

@@ -44,7 +45,7 @@ FROM checkmarx/kics:alpine as kics
FROM trufflesecurity/trufflehog:latest as trufflehog
FROM jdkato/vale:latest as vale
FROM lycheeverse/lychee:latest-alpine as lychee
FROM ghcr.io/terraform-linters/tflint:v0.51.0 as tflint
FROM ghcr.io/terraform-linters/tflint:v${TFLINT_VERSION} as tflint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but maybe I'll have to include the v inside the env var. And anyways, if someone wants to use the variable to point to a different tag, that restricts to tags starting with v

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep SEMVER values for versions ^^

@nvuillam nvuillam merged commit 178d6a8 into main Jun 2, 2024
126 checks passed
@nvuillam nvuillam deleted the dependencies/tflint3 branch June 2, 2024 09:53
@nvuillam
Copy link
Member Author

nvuillam commented Jun 2, 2024

@echoix i merged coz i'd like to make a new release today, but we can make updates, like maybe an intermediate variable with docker image name that would be calculated from version semver if not overridden :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants