Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptors for authenticating Github API calls #2299

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Jan 29, 2023

Partly solves #2256

@bdovaz bdovaz requested a review from nvuillam as a code owner January 29, 2023 19:44
@nvuillam
Copy link
Member

nvuillam commented Jan 29, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.16s
✅ BASH shfmt 6 0 0 0.35s
✅ COPYPASTE jscpd yes no 2.83s
✅ DOCKERFILE hadolint 105 0 9.31s
✅ JSON eslint-plugin-jsonc 21 0 0 2.11s
✅ JSON jsonlint 19 0 0.27s
✅ JSON v8r 21 0 11.95s
⚠️ MARKDOWN markdownlint 309 0 231 6.7s
✅ MARKDOWN markdown-link-check 309 0 5.42s
✅ MARKDOWN markdown-table-formatter 309 0 0 17.79s
✅ OPENAPI spectral 1 0 1.73s
⚠️ PYTHON bandit 176 45 3.85s
✅ PYTHON black 176 0 0 4.43s
✅ PYTHON flake8 176 0 2.33s
✅ PYTHON isort 176 0 0 0.75s
✅ PYTHON mypy 176 0 6.76s
✅ PYTHON pylint 176 0 11.39s
⚠️ PYTHON pyright 176 276 16.84s
✅ REPOSITORY checkov yes no 27.75s
✅ REPOSITORY git_diff yes no 0.34s
✅ REPOSITORY secretlint yes no 13.58s
✅ REPOSITORY trivy yes no 23.31s
✅ SPELL cspell 729 0 18.56s
✅ SPELL misspell 550 0 0 0.86s
✅ XML xmllint 3 0 0 0.34s
✅ YAML prettier 81 0 0 2.84s
✅ YAML v8r 23 0 54.42s
✅ YAML yamllint 82 0 1.06s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes, this PR will be life-saving for concurrent builds :)

@nvuillam
Copy link
Member

cat: can't open '/run/secrets/GITHUB_TOKEN': No such file or directory

ooooops

@nvuillam
Copy link
Member

nvuillam commented Feb 11, 2023

image

At super-linter they do that in their Dockerfile

ARG GITHUB_TOKEN in Dockerfile

Add --mount=type=secret,id=GITHUB_TOKEN at the beginning of a RUN instruction

Do you want to try, or do you prefer I try on your branch ? (it may be complex to update my mess in build.py ^^ )

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 11, 2023

@nvuillam more info: docker/build-push-action#754

If you can give me a hand better because I have to leave soon and I won't be able to do anything until tomorrow.

@nvuillam
Copy link
Member

Sure, I'll try to fix that :)

Have a good afternoon:)

@nvuillam
Copy link
Member

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.15s
✅ BASH shfmt 6 0 0 0.03s
✅ COPYPASTE jscpd yes no 2.94s
✅ DOCKERFILE hadolint 105 0 8.69s
✅ JSON eslint-plugin-jsonc 21 0 0 1.78s
✅ JSON jsonlint 19 0 0.26s
✅ JSON npm-package-json-lint yes no 0.63s
✅ JSON v8r 21 0 12.12s
⚠️ MARKDOWN markdownlint 309 0 231 6.02s
✅ MARKDOWN markdown-link-check 309 0 5.28s
✅ MARKDOWN markdown-table-formatter 309 0 0 16.75s
✅ OPENAPI spectral 1 0 1.64s
⚠️ PYTHON bandit 176 45 2.14s
✅ PYTHON black 176 0 0 3.2s
✅ PYTHON flake8 176 0 1.71s
✅ PYTHON isort 176 0 0 0.47s
✅ PYTHON mypy 176 0 7.0s
✅ PYTHON pylint 176 0 11.27s
⚠️ PYTHON pyright 176 274 17.37s
✅ REPOSITORY checkov yes no 27.79s
⚠️ REPOSITORY devskim yes 61 1.24s
✅ REPOSITORY dustilock yes no 1.31s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 8.44s
✅ REPOSITORY syft yes no 0.96s
✅ REPOSITORY trivy yes no 20.41s
✅ SPELL cspell 729 0 17.5s
✅ SPELL misspell 550 0 0 0.54s
✅ XML xmllint 3 0 0 0.02s
✅ YAML prettier 81 0 0 2.51s
✅ YAML v8r 23 0 58.91s
✅ YAML yamllint 82 0 1.13s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants