Open
Conversation
Contributor
Author
|
Ran into an issue that needs to be resolved caused by this change before the PR is ready to be merged. |
Contributor
Author
This issue is fine because it happened from expected behaviour. The error message has now been improved to include more details. |
844037b to
b69525b
Compare
Now, anarci keeps going in the sequences to find more annotations and the numbering pipeline handles gaps in the sequences.
b69525b to
567f6c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the annotations to improve the IMGT numbering for molecules. Previously, MHC class I were only being half numbered because anarci would find the first hit, and then that would be passed back and used as annotations. Now, anarci keeps going until no more annotations can be found for a sequence, and these are used to number the whole molecule. These changes also update how scTCRs are identified.
These changes also rely on a fix that is staged as a PR in anarci (https://github.com/npqst/anarci-mhc/pull/5). There is an issue with how CD1 molecules are currently identified by anarci.
I also added a fix for interaction profiling that addresses #75, because the updated numbering uncovered some potential issues with how the conversion between PLIP and PDB numbering was working.