Open
Conversation
alexpilotti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 206cfa9 provides a way to extend ParagraphDataset by overriding _load_pdb_data(...). This is useful for example when loading data using a different file format or when processing the PDB data after loading it (e.g. adjusting the residue numbering). This is just a minor refactoring with no change in the default functionality.
Commit 9c4c47b adds the search_area parameter to ParagraphDataset's __init__(...) in order to set it to either IMGT_CDRplus2 or IMGT_CDR at runtime (previously this required a code change). By default the current setting is preserved (IMGT_CDRplus2).
Commit cf3e1c2 removes all trailing whitespaces in dataset.py for PEP8 compliance, useful in particular when using modern editors with automated whitespace trimming settings, avoiding unrelated changes in further commits.