switch to HiGHS solver #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by issues with CBC on Apple M1/M2 architectures: - jump-dev/Clp.jl#131 - http://github.com/daschw/SankeyPlots.jl/issues/26 Moreover there seems to be a slight performance advantage overall: HiGHS: Test Summary: | Pass Total Time LayeredLayouts.jl | 20 20 17.4s Test Summary: | Pass Total Time LayeredLayouts.jl | 20 20 19.3s CBC: Test Summary: | Pass Total Time LayeredLayouts.jl | 20 20 20.5s Test Summary: | Pass Total Time LayeredLayouts.jl | 20 20 20.6s However, the `direct/sankey_3twos.png` and `paths/sankey_3twos.png` results to be flipped with this solver:
oxinabox
approved these changes
Apr 10, 2023
oxinabox
reviewed
Apr 10, 2023
Co-authored-by: Frames White <oxinabox@ucc.asn.au>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 4 4
Lines 204 204
=======================================
Hits 186 186
Misses 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
oxinabox
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by issues with CBC on Apple M1/M2 architectures:
Moreover there seems to be a slight performance advantage overall:
HiGHS:
Test Summary: | Pass Total Time
LayeredLayouts.jl | 20 20 17.4s
Test Summary: | Pass Total Time
LayeredLayouts.jl | 20 20 19.3s
CBC:
Test Summary: | Pass Total Time
LayeredLayouts.jl | 20 20 20.5s
Test Summary: | Pass Total Time
LayeredLayouts.jl | 20 20 20.6s
However, the
direct/sankey_3twos.pngandpaths/sankey_3twos.pngresults to be flipped with this solver:HiGHS:
CBC:
