Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ordering #19

Merged
merged 11 commits into from
Feb 8, 2022
Merged

Node ordering #19

merged 11 commits into from
Feb 8, 2022

Conversation

davide-f
Copy link
Contributor

@davide-f davide-f commented Feb 7, 2022

This commit attempts to solve the issue #12 to set the ordering of selected nodes.

This branch is also the updated version of previous #17 ; it is built on top of the pull request #16 where the tests are modified to accommodate optional arguments.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #19 (aeadf16) into main (baea9a4) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   92.09%   92.22%   +0.13%     
==========================================
  Files           4        4              
  Lines         177      180       +3     
==========================================
+ Hits          163      166       +3     
  Misses         14       14              
Impacted Files Coverage Δ
src/zarate.jl 90.51% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baea9a4...aeadf16. Read the comment docs.

@davide-f
Copy link
Contributor Author

davide-f commented Feb 7, 2022

@oxinabox Thank you for your interest on the other PR #16 ; may you crosscheck also this PR (it was inherited from the old #17 )
CI works and I added also other tests. Once the PR #16 is merged, we may merge also this one

@oxinabox
Copy link
Owner

oxinabox commented Feb 7, 2022

this will now need rebasing as i merged your other PR

@davide-f
Copy link
Contributor Author

davide-f commented Feb 7, 2022

@oxinabox Done; I also set the input type to be Vector{Pair}

@oxinabox
Copy link
Owner

oxinabox commented Feb 8, 2022

Nice LGTM

@oxinabox oxinabox merged commit dcfb1e9 into oxinabox:main Feb 8, 2022
@davide-f davide-f deleted the node_ordering branch February 8, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants