Update syn to 2.0 #231
Merged
Update syn to 2.0 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much appreciated, since I wasn't planning on continuing that work after being laid off from my job at Shopify |
|
I'm 👍🏻 with this, 1.60 is available on latest ubuntu for users that don't use rustup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the changes from #171 (Thanks @dylanahsmith, hope you don't mind), rebases them on main, and adds a couple more.
The motivation behind this is, I've updated Magnus to syn 2.0 and it'd be nice to have rb-sys and Magnus be able to use the same syn so it only need to be compiled once.
The biggest change is probably upping the minimum supported Rust version to 1.60, so that bindgen can be updated to 0.66, so that its syn dependency is upped to 2.0. Without this change the whole motivation for making any change is lost. Increasing the MSRV isn't something that bothers me right now as I'm going to be increasing it to 1.61 in Magnus, but if it doesn't work with your plans, then no worries, this whole change is just a nice to have, not critical, I'd be ok with dropping it.