Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 31, 2025

This PR introduces a new attrs setting that can be used to apply attributes to generated types.

Supersedes #707

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; do you have a proposal for how we test it?

@ghost ghost marked this pull request as draft January 4, 2026 21:14
@ghost ghost changed the title feat: introduce attrs setting feat!: introduce attrs setting Jan 4, 2026
@ghost ghost marked this pull request as ready for review January 4, 2026 22:49
@ghost ghost force-pushed the feat/introduce-attrs branch from 893f600 to bd5c9d9 Compare January 5, 2026 18:15
@ahl
Copy link
Collaborator

ahl commented Jan 8, 2026

Let me know when it's ready for review. Thanks!

@ghost
Copy link
Author

ghost commented Jan 8, 2026

Let me know when it's ready for review. Thanks!

This one is ready.

Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff; thanks

@ahl ahl merged commit f856450 into oxidecomputer:main Jan 11, 2026
4 checks passed
@ahl ahl mentioned this pull request Jan 11, 2026
@ghost ghost deleted the feat/introduce-attrs branch January 11, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant