ArtifactKind could support daft::Diffable
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
reviewed
Mar 6, 2025
Collaborator
iliana
left a comment
iliana
left a comment
There was a problem hiding this comment.
I don't have CI set up yet, but this doesn't pass cargo fmt. Otherwise looks fine.
iliana
approved these changes
Mar 6, 2025
Contributor
Author
|
Thanks. Fixed, and also checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is wanted for oxidecomputer/omicron#7741, which adds
ArtifactKindto the blueprint (and so needs to beDiffable).