vpc_firewall_rules: fix provider produced invalid plan

[sudomateo]

Added acceptance tests to surface the issue reported in #453.

See #453 (comment) for an understanding of what's happening.

Removed the computed attributes from the firewall rules since those computed fields were being updated for all of the rules, even when Terraform did not expect a rule to be updated. Unfortunately all of the computed attributes had to be removed for this to work and keep the update in-place logic.

[sudomateo]

> TEST_ACC_NAME=TestAccCloudResourceFirewallRules make testacc
-> Running terraform acceptance tests
=== RUN   TestAccCloudResourceFirewallRules_full
=== PAUSE TestAccCloudResourceFirewallRules_full
=== CONT  TestAccCloudResourceFirewallRules_full
--- PASS: TestAccCloudResourceFirewallRules_full (9.36s)
PASS
ok      github.com/oxidecomputer/terraform-provider-oxide/internal/provider     9.367s

[karencfv]

Thanks for tackling this! Looks good.

Could you add an entry to the changelog for a breaking change since we're changing the schema?

[sudomateo]

Changelog added and tests are passing.

> TEST_ACC_NAME=TestAccCloudResourceFirewallRules make testacc
-> Running terraform acceptance tests
=== RUN   TestAccCloudResourceFirewallRules_full
=== PAUSE TestAccCloudResourceFirewallRules_full
=== CONT  TestAccCloudResourceFirewallRules_full
--- PASS: TestAccCloudResourceFirewallRules_full (12.00s)
PASS
ok      github.com/oxidecomputer/terraform-provider-oxide/internal/provider     12.002s

[karencfv]

Thanks for addressing my comments! Sorry, I just realised we need to update the resource's documentation as well with the schema changes https://github.com/oxidecomputer/terraform-provider-oxide/blob/main/docs/resources/oxide_vpc_firewall_rules.md

[sudomateo]

Thanks for addressing my comments! Sorry, I just realised we need to update the resource's documentation as well with the schema changes https://github.com/oxidecomputer/terraform-provider-oxide/blob/main/docs/resources/oxide_vpc_firewall_rules.md

No worries! I forgot too. Heat wave is making my brain melt this week haha.

[karencfv]

Looks great! Thanks for the fix!