Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[propolis-client] ensure that InstanceSerialConsoleHelper is Send #445

Conversation

sunshowers
Copy link
Contributor

We regressed on this in #435. Ensure that it's Send, and statically
assert it.

Created using spr 1.3.4
@sunshowers sunshowers requested review from leftwo and lifning June 21, 2023 19:31
Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@sunshowers sunshowers merged commit 1623ddc into master Jun 21, 2023
@sunshowers sunshowers deleted the sunshowers/spr/propolis-client-ensure-that-instanceserialconsolehelper-is-send branch June 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants