Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 3, 2023

This only moves them into a crate to allow building them.
The next step would be to add a CI job that builds them.

pub mod buildomat_builder;
pub mod buildomat_builder_tagged;
pub mod buildomat_cli;
//pub mod buildomat_httpmock;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out due to #637

@ahl
Copy link
Collaborator

ahl commented Dec 7, 2023

What would you think about doing the JsonSchema -> schemars::JsonSchema and the file renames first?

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 7, 2023

Ya I can split it up

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 8, 2023

There is a lot of overlap, so would be good to get #641 in quickly.

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 13, 2023

This PR now sits on top of #642

@jayvdb jayvdb changed the title Build generated clients Move generated clients into a buildable crate Jan 6, 2024
@jayvdb jayvdb changed the title Move generated clients into a buildable crate Move test generated clients into a buildable crate Jan 6, 2024
@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 6, 2024

@ahl , PR refreshed & green.

@ahl ahl merged commit d3e8923 into oxidecomputer:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants