Refactor: move HttpClient into Api
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction between
ApiandHttpClientalways bothered me. It's not there for any reason — we don't useHttpClientby itself for anything and nothing else extends it. In theory we could test it without having to generate the client around it, but we don't — our tests are unit tests on functions used byHttpClient(handleResponse,mergeParams) but not onHttpClientitself. If we wanted smaller tests like that, a more effective approach would be to generate a minimal client with a nearly empty OpenAPI schema and then test that.I tested the client generated by this PR manually in the web console by copying it in and running the tests.