generate: handle map[string]any types correctly.#325
Merged
Conversation
lgfa29
approved these changes
Aug 29, 2025
sudomateo
reviewed
Aug 29, 2025
jmcarp
force-pushed
the
jmcarp/map-string-object
branch
from
0dfcc88 to
8d42079
Compare
When an openapi field includes an `additionalProperties` key, it represents a map to the type specified in the schema reference. We already correctly handle the special case of mapping a string to a slice of the referenced type as a `map[string][]type`, but not the case where the nested type isn't a slice. This patch adds logic for the missing `map[string[type` case.
jmcarp
force-pushed
the
jmcarp/map-string-object
branch
from
8d42079 to
1649b1e
Compare
sudomateo
approved these changes
Aug 29, 2025
Collaborator
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
Looks good! We'll bump the Omicron version in a future commit which will bring in the new []Timeseries type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an openapi field includes an
additionalPropertieskey, it represents a map to the type specified in the schema reference. We already correctly handle the special case of mapping a string to a slice of the referenced type as amap[string][]type, but not the case where the nested type isn't a slice. This patch adds logic for the missingmap[string[typecase.