Skip to content

Conversation

@sudomateo
Copy link
Collaborator

Update to Go 1.24. Also, update the dependencies to be compatible with Go 1.24.

@sudomateo sudomateo force-pushed the sudomateo/go-1.24 branch from 5175d85 to 3765af8 Compare May 29, 2025 03:52
@sudomateo sudomateo requested a review from karencfv May 29, 2025 03:53
@sudomateo sudomateo force-pushed the sudomateo/go-1.24 branch 3 times, most recently from f96e5e1 to 4316be3 Compare May 29, 2025 04:24
@sudomateo
Copy link
Collaborator Author

The setup-go GitHub Actions action was updated to install the version of Go from the go.mod file to prevent the 1.x cache from being used which contained Go 1.23.9 when we really wanted Go 1.24.3.

There's some interesting CI/CD behavior here where the workflows run on pull_request events but the generate workflow can push a commit when the diff is non-zero which is a push event, not a pull_request event. The result is that the pull request will wait for the build-test check to pass but it'll never run because it's waiting for a pull_request event but only received a push event. Probably worth discussing the desired flow of CI for this repository and seeing if we want to change the trigger to push instead of pull_request.

Copy link
Collaborator

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for working on this! Just a small nit on making the changelog entry more explicit.

@karencfv
Copy link
Collaborator

There's some interesting CI/CD behavior here where the workflows run on pull_request events but the generate workflow can push a commit when the diff is non-zero which is a push event, not a pull_request event. The result is that the pull request will wait for the build-test check to pass but it'll never run because it's waiting for a pull_request event but only received a push event. Probably worth discussing the desired flow of CI for this repository and seeing if we want to change the trigger to push instead of pull_request.

Ugh, that bot. I had forgot about it since I work from a fork. I am 100% OK with getting rid of that bot altogether unless you think it's useful.

Update to Go 1.24. Also, update the dependencies to be compatible with Go 1.24.
@sudomateo sudomateo force-pushed the sudomateo/go-1.24 branch from 4316be3 to 7e6137f Compare May 29, 2025 13:31
@sudomateo sudomateo merged commit 855352f into main May 29, 2025
2 checks passed
@sudomateo sudomateo deleted the sudomateo/go-1.24 branch May 29, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants