misc: downgrade indirect dependency #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #122 this project would fail to build with the following error. ``` > go build . # k8s.io/apimachinery/pkg/util/managedfields/internal ../../.local/gopath/pkg/mod/k8s.io/apimachinery@v0.33.4/pkg/util/managedfields/internal/typeconverter.go:51:61: cannot use typeSchema.Types (variable of type []"sigs.k8s.io/structured-merge-diff/v6/schema".TypeDef) as []"sigs.k8s.io/structured-merge-diff/v4/schema".TypeDef value in struct literal ``` Yes, I know we need CI/CD. It's coming! I ran `go mod graph` and noticed that all packages used `sigs.k8s.io/structured-merge-diff/v4` except for `k8s.io/kube-openapi` which used `sigs.k8s.io/structured-merge-diff/v6`. ``` > go mod graph k8s.io/api@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/apimachinery@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/apiserver@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/client-go@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/cloud-provider@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/component-base@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/component-helpers@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/controller-manager@v0.33.4 sigs.k8s.io/structured-merge-diff/v4@v4.6.0 k8s.io/kube-openapi@v0.0.0-20250814151709-d7b6acb124c3 sigs.k8s.io/structured-merge-diff/v6@v6.2.0 ``` I downgraded `k8s.io/kube-openapi` to the commit just before it upgraded to `sigs.k8s.io/structured-merge-diff/v6`. ``` > go get -u k8s.io/kube-openapi@9bd5c66d9911c53f5aedb8595fde9c229ca56703 go: downgraded k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3 => v0.0.0-20250701173324-9bd5c66d9911 ``` All good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #122 this project would fail to build with the following error.
Yes, I know we need CI/CD. It's coming!
I ran
go mod graphand noticed that all packages usedsigs.k8s.io/structured-merge-diff/v4except fork8s.io/kube-openapiwhich usedsigs.k8s.io/structured-merge-diff/v6.I downgraded
k8s.io/kube-openapito the commit just before it upgraded tosigs.k8s.io/structured-merge-diff/v6.All good now!