ExampleSystemBuilder: use idiomatic getter/setter names#9796
Open
jgallagher wants to merge 5 commits intojohn/planning-input-pruneablefrom
Open
ExampleSystemBuilder: use idiomatic getter/setter names#9796jgallagher wants to merge 5 commits intojohn/planning-input-pruneablefrom
jgallagher wants to merge 5 commits intojohn/planning-input-pruneablefrom
Conversation
davepacheco
approved these changes
Feb 4, 2026
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Thank you! This was bugging me, too.
sunshowers
reviewed
Feb 4, 2026
Contributor
sunshowers
left a comment
sunshowers
left a comment
There was a problem hiding this comment.
Thanks for doing this! It's been bugging me too
| /// Currently, this value can be anywhere between 0 and 5. (More can be | ||
| /// added in the future if necessary.) | ||
| pub fn nsleds(mut self, nsleds: usize) -> Self { | ||
| pub fn set_nsleds(mut self, nsleds: usize) -> Self { |
Contributor
There was a problem hiding this comment.
They're owned builder methods so I'd call them with_*.
Contributor
Author
There was a problem hiding this comment.
Ahh yeah good call. Will tweak momentarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #9730, where I was touching this code and the naming bugged me.