Draft
Conversation
Collaborator
Author
|
Related: #9349. |
…es' into dap/remove-unused-dns-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #9782.
While working on better coverage for the example system DNS resolution test, I found that three ServiceName variants are unused:
Wicketd,Tfport,Maghemite. I've dug around a bit and I think we can remove these. They are not ever actually created and no consumer appears to use them. We can always add them if we find these useful in the future.Methodology:
omdb db dns names internalto fetch the latest contents of internal DNS and did not find the corresponding DNS names (_tfport,_maghemite, and_wicketd).cargo xtask ls-apisto list APIs exposed by each of these components, then again to find consumers of those APIs, then searched the corresponding source for use of those clients to figure out how they're discovering their dependencies.Excerpts from
cargo xtask ls-apis servers(shows which APIs are exposed by these components):From
cargo xtask ls-apis apis, finding these APIs' consumers:The full dogfood latest internal DNS:
Details
My notes from looking at the clients:
tfport has no servers.
Wicketd (supposedly) only exposes APIs to installinator. (I know Wicket also exists and I'm guessing it's omitted here by metadata.)
I also looked at
mg_admin_clientbecause I wasn't sure if that was whatMaghemitemight refer to, but I don't think so because at least one consumer usesServiceName::Mgdfor this and another usesMGD_PORT.So my conclusion is that it's not obvious these consumers should be using DNS and they're certainly not today so we can remove this. Again, we can always re-add it.