Wire up public API for managing subnet pools

[bnaecker]

• Wires up the subnet pool and subnet pool member CRUD to the database operations. Partial fix for Control plane support for attached subnets. #9453.
• Adds integration tests for these plus some resource helpers.
• New API version to remove pool type from the subnet pools and the name. Fixes Minor cleanup of subnet pool API #9740.

[david-crespo]

Still planning on doing this part? Looks like kind of a lot of stuff on the member struct.

Subnet pool members, the individual subnets in them, currently have all the identity metadata that most API resources have, like a name, description, etc. I think we want these to be more like IP Pool Ranges, where the only identifying information is a UUID and the CIDR block itself. You can't update these, and names don't really do anything for you, since the IP subnet is the identity of the thing.

[bnaecker]

Well that's fun. Looks like we hit a 2h timeout, presumably in Buildomat, and the whole job was killed. I'm rerunning it.

[bnaecker]

Still planning on doing this part? Looks like kind of a lot of stuff on the member struct.

Subnet pool members, the individual subnets in them, currently have all the identity metadata that most API resources have, like a name, description, etc. I think we want these to be more like IP Pool Ranges, where the only identifying information is a UUID and the CIDR block itself. You can't update these, and names don't really do anything for you, since the IP subnet is the identity of the thing.

Did I not do that? I'm very confused.

The latest commit in my branch is:

bnaecker@shale : ~/omicron $ git log --oneline -2
1822c4c32 (HEAD -> wire-up-subnet-pool-crud-api, origin/wire-up-subnet-pool-crud-api) Review feedback
69c435641 Wire up public API for managing subnet pools

If you click on "Commits" above, you get to this list, which has those exact hashes. Browsing the repo at that point and getting to the right file shows:

omicron/nexus/types/src/external_api/views.rs

Lines 480 to 497 in 1822c4c

	pub struct SubnetPoolMember {
	/// ID of the pool member
	pub id: Uuid,
	/// Time the pool member was created.
	pub time_created: DateTime<Utc>,
	/// ID of the parent subnet pool
	pub subnet_pool_id: Uuid,
	/// The subnet CIDR
	pub subnet: IpNet,
	/// Minimum prefix length for allocations from this subnet; a smaller prefix
	/// means larger allocations are allowed (e.g. a /16 prefix yields larger
	/// subnet allocations than a /24 prefix).
	pub min_prefix_length: u8,
	/// Maximum prefix length for allocations from this subnet; a larger prefix
	/// means smaller allocations are allowed (e.g. a /24 prefix yields smaller
	/// subnet allocations than a /16 prefix).
	pub max_prefix_length: u8,
	}

Am I missing something?

[david-crespo]

Sorry! I think I was looking at an out of date diff or maybe I just misread it. Got it, looks good. (output from my api-diff tool that diffs the TS client)

[david-crespo]

This resulted in this change to the query params. Seems right since there is no longer any name to sort by.

[bnaecker]

Yeah, we're sorting by IP subnet.