[rfd-599] Implement skeleton subnet pools and external subnets APIs#9634
Merged
mergeconflict merged 3 commits intomainfrom Jan 21, 2026
Merged
Conversation
bnaecker
reviewed
Jan 15, 2026
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
Looks pretty good, some questions about API consistency and overall shape. Like where it's going!
mergeconflict
changed the base branch from
main
to
spr/mergeconflict/main.rfd-599-implement-skeleton-subnet-pools-api
mergeconflict
added a commit
that referenced
this pull request
Jan 16, 2026
…david-crespo's feedback Created using jj-spr 0.1.0
mergeconflict
changed the base branch from
spr/mergeconflict/main.rfd-599-implement-skeleton-subnet-pools-api
to
main
This was referenced Jan 20, 2026
bnaecker
approved these changes
Jan 21, 2026
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
Looks good! I've got a couple of small naming nits, but take them or leave them. Thanks for iterating on this.
mergeconflict
force-pushed
the
spr/mergeconflict/rfd-599-implement-skeleton-subnet-pools-api
branch
from
d59e3a7 to
1e75a22
Compare
Reviewers: Pull Request: #9634
mergeconflict
force-pushed
the
spr/mergeconflict/rfd-599-implement-skeleton-subnet-pools-api
branch
from
03ca64f to
a234873
Compare
Based on #9634, this PR implements a skeleton `/v1/external-subnets` REST API for allocating external subnets from subnet pools, and attaching them to instances, as described in [RFD 599](https://rfd.shared.oxide.computer/rfd/0599#_external_subnets).
mergeconflict
changed the title
mergeconflict
deleted the
spr/mergeconflict/rfd-599-implement-skeleton-subnet-pools-api
branch
ahl
reviewed
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a skeleton
/v1/system/subnet-poolsand/v1/external-subnetsREST API for allocating external subnets from subnet pools, and attaching them to instances, as described in RFD 599.